Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies for protocol 21 #135

Merged
merged 30 commits into from
Apr 18, 2024
Merged

Bump dependencies for protocol 21 #135

merged 30 commits into from
Apr 18, 2024

Conversation

2opremio
Copy link
Contributor

No description provided.

@2opremio 2opremio marked this pull request as ready for review April 15, 2024 15:59
@2opremio 2opremio requested a review from dmkozh April 15, 2024 15:59
@2opremio
Copy link
Contributor Author

System tests are not going to work until protocol 21 support is included in quickstart.

@2opremio
Copy link
Contributor Author

2opremio commented Apr 17, 2024

@dmkozh I enabled protocol 20 integration testing and the simulation library fails with:

cannot create budget from network configuration
        	            	
        	            	Caused by:
        	            	    HostError: Error(Budget, InternalError)
        	            	    DebugInfo not available

I double-checked that we are passing down the right protocol number (20).

All protocol 21 tests are passing without problems.

@2opremio
Copy link
Contributor Author

@sreuland I presume system tests are still using version 20 of the protocol, which would explain why they are failing.

@2opremio 2opremio merged commit fa96faa into main Apr 18, 2024
20 checks passed
@2opremio 2opremio deleted the protocol21 branch April 18, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants